Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix on_train_batch_start hook to end epoch early #3700

Merged
merged 6 commits into from
Oct 2, 2020
Merged

Fix on_train_batch_start hook to end epoch early #3700

merged 6 commits into from
Oct 2, 2020
+28 −4

Conversation

ydcjeff
Copy link
Contributor

@ydcjeff ydcjeff commented Sep 28, 2020

What does this PR do?

Fixes #3693

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@mergify mergify bot requested a review from a team September 28, 2020 12:38
@ydcjeff ydcjeff changed the title Fix on_train_batch_start to end epoch Fix on_train_batch_start to end epoch early Sep 28, 2020
@ydcjeff ydcjeff changed the title Fix on_train_batch_start to end epoch early Fix on_train_batch_start hook to end epoch early Sep 28, 2020
@ydcjeff
Copy link
Contributor Author

ydcjeff commented Sep 30, 2020

It's ready to review.

@Borda Borda added the bug Something isn't working label Oct 2, 2020
Borda
Borda reviewed Oct 2, 2020
View reviewed changes
tests/models/test_hooks.py Outdated Show resolved Hide resolved
@mergify mergify bot requested a review from a team October 2, 2020 17:39
@Borda
Apply suggestion from code review
dcdbaee 
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Borda
Borda approved these changes Oct 2, 2020
View reviewed changes
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mergify mergify bot requested a review from a team October 2, 2020 18:04
@codecov
Copy link

codecov bot commented Oct 2, 2020

Codecov Report

Merging #3700 into master will decrease coverage by 6%.
The diff coverage is 33%.

@@           Coverage Diff            @@
##           master   #3700     +/-   ##
========================================
- Coverage      85%     79%     -6%     
========================================
  Files         110     112      +2     
  Lines        8387   10236   +1849     
========================================
+ Hits         7170    8114    +944     
- Misses       1217    2122    +905

SkafteNicki
SkafteNicki approved these changes Oct 2, 2020
View reviewed changes
Copy link
Member

@SkafteNicki SkafteNicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@mergify mergify bot requested a review from a team October 2, 2020 18:39
@Borda Borda added the ready PRs ready to be merged label Oct 2, 2020
rohitgr7
rohitgr7 approved these changes Oct 2, 2020
View reviewed changes
Copy link
Contributor

@rohitgr7 rohitgr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@Borda Borda merged commit 9942f3e into Lightning-AI:master Oct 2, 2020
@ydcjeff ydcjeff deleted the bugfix/on-train-batch-start-3693 branch October 3, 2020 02:17
@Borda Borda added this to the 0.10.0 milestone Oct 7, 2020
@carmocca carmocca mentioned this pull request May 24, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

@SkafteNicki SkafteNicki SkafteNicki approved these changes

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@awaelchli awaelchli Awaiting requested review from awaelchli

@nateraw nateraw Awaiting requested review from nateraw

@teddykoker teddykoker Awaiting requested review from teddykoker

@tullie tullie Awaiting requested review from tullie

Assignees
No one assigned
Labels
bug Something isn't working ready PRs ready to be merged
Projects
None yet
Milestone
pl:0.10
Development

Successfully merging this pull request may close these issues.

Missing attribute "training_step_output_for_epoch_end"
4 participants
@ydcjeff @Borda @SkafteNicki @rohitgr7